]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
loginDialog: Pass tracked object to connectObject() calls
authorFlorian Müllner <fmuellner@gnome.org>
Thu, 3 Sep 2026 17:51:05 +0000 (19:51 +0200)
committerFlorian Müllner <fmuellner@gnome.org>
Sun, 13 Sep 2026 17:39:10 +0000 (19:39 +0200)
Otherwise the handler will be associated with the `globalThis`
object and never get disconnected automatically.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4382>
(cherry picked from commit eafb4e601904222bb8d6b2c3aa88b264338f374a)

js/gdm/loginDialog.js

index 4ec381f4a46261dee1854405e0ddf87bba54c77c..25bfb26f6d3a7862fb4bbf6dbd79187d5c62a401 100644 (file)
@@ -904,7 +904,7 @@ export const LoginDialog = GObject.registerClass({
                         this._userManager.disconnectObject(this);
                         this._loadUserList();
                     }
-                });
+                }, this);
         } else {
             const id = GLib.idle_add_once(GLib.PRIORITY_DEFAULT, this._loadUserList.bind(this));
             GLib.Source.set_name_by_id(id, '[gnome-shell] _loadUserList');